[Conkeror] [PATCH] A `bury-buffer' command

John J Foerch jjfoerch at earthlink.net
Wed Aug 27 11:39:30 PDT 2008


David House <dmhouse <at> gmail.com> writes:
> So I had a little go at hacking on conkeror today, and thought I'd
> start fairly simply: I've added a `bury-buffer' command which moves
> the current buffer to the end of the buffer list, so as to make it the
> least likely buffer to get selected by `switch-to-buffer'.
>
> ...
> 
> Comments welcome! This is my first (not completely trivial) bit of
> code for conkeror, so I don't doubt I've got something wrong.
> 


Christoph Ruegge <cruegge at gmx.de> writes:
> Hi,
>
> the function does not update the mode-line properly. I think this might be fixed
> by adding select_buffer_hook.run(new_buffer) after switching.

Reviewing the code, it looks like the workhorse of updating everything
is the `buffer_container.current' setter function, called by
`switch_to_buffer' but not called by `bury_buffer'.  It seems like
bury_buffer really ought to be working through that setter rather than
duplicating its work.  However, `current' may need to be altered to
accomodate `bury_buffer'.

David: would you mind looking into this when you have time?

-- 
John Foerch



More information about the Conkeror mailing list