[Conkeror] [PATCH] Typing a substring of a hint now respects a disabled hints_auto_exit_delay.

[Jeremy Maitin-Shepard]

John J Foerch <jjfoerch at earthlink.net> writes:

[snip]

>   When hints_auto_exit_delay is 0, no auto-exit is supposed to happen at
> all, as it says in the docstring.  If that is broken, there must be a
> deeper bug involved in the handling of the variable
> hints_minibuffer_state.auto_exit.

He is correct that the behavior is currently buggy.

>   I'm also noticing the strange ways in which hints_auto_exit_delay and
> hints_ambiguous_auto_exit_delay are getting passed around in hints.js,
> with separate handling of number keys (hints-handle-number command)
> vs. other characters (hints_minibuffer_state.handle_input).

>   I think this calls for a deeper refactoring, possibly removing the
> command hints-handle-number.

I think removing the command and handling both text and number input
together would end up making things more complicated.  However, I agree
that passing around all of the delays is more complicated than
necessary.  I've pushed a fix.

To David:

Thanks very much for pointing out the problem.  As suggested by John,
I'm going to refactor the passing around of delays, and therefore I
won't be applying your patch directly.

-- 
Jeremy Maitin-Shepard