[Conkeror] [RFC] Show more links on mouse over.

[John J Foerch]

David Kettler <David.Kettler at dsto.defence.gov.au> writes:
> Previously only simple links were shown in the echo area when the
> mouse was hovered over the link.  Now image links and links containing
> formatting will also be shown.
> ---
>
> An example where this makes a difference is at the conkeror webgit
> http://repo.or.cz/w/conkeror.git.  The git image in the top right
> corner is clickable but without this patch it doesn't show the link on
> mouseover.
>
> This patch copies the parent chasing code from
> element_get_load_spec().  That's more expensive than the previous
> code, but I don't notice any performance degradation on my box.
>
> My main concern with the approach though, is that I want a guarantee
> that the link I see when I hover is what I'll get when I click.  But
> the current code has seperate implementations for these two cases, so
> the result may differ.
>
> I considered calling element_get_load_spec() from the event handler,
> but it seems rather heavy weight.
>
> I wonder if it's possible to hook in while the DOM is being
> constructed and attach the href from an anchor element to its bottom
> level child.  And do some of the other cases handled by
> element_get_load_spec() at that time too.  Then the simplified
> element_get_load_spec() and the mouseover event handler need only
> check the element for a href; they will get the same result.

Thank you.  I'm just now getting caught up on reviewing patches, so
sorry for the wait on this one.  I think your concern about consistency
between the notification text and the url that gets used upon the click
event is very valid, and something we should look into.  However, this
patch is definitely a positive incremental improvement on conkeror's
current rollover notification.  Perhaps the rollover notification text
should also contain information about any onclick handlers registered
for the nodes being hovered over.

-- 
John Foerch