[Conkeror] [PATCH] Support *either* bookmark user titles *or* combined completion

[John J Foerch]

David Kettler <David.Kettler at dsto.defence.gov.au> writes:
> Commit bd0d4c9b80 (Support *either* history *or* bookmarks in read_url
> completions) added support for completion on bookmark user titles, but
> disallows completion on both bookmarks and history.
>
> With this commit the user can choose which kind of brokenness they
> prefer by setting use_broken_bookmark_completion.  It is expected that
> this variable will be ignored and deprecated once QUERY_TYPE_UNIFIED
> works.

Hi David,

  Can you explain what feature you would like Conkeror to have, in
positive terms independent of the bug in the completion code?  I think
that adding a user variable to optionally regress to a known bug is the
wrong way to go about solving this problem.  Naming a feature "broken
bookmark completion" doesn't really say what that feature is.

  Also the default query type is QUERY_TYPE_HISTORY, so perhaps conkeror
can already do what you want it to do, as follows:

 url_completion_use_history = true;
 url_completion_use_bookmarks = false;

-- 
John Foerch