[Conkeror] [patch] some trivial fixes

Jeremy Maitin-Shepard jeremy at jeremyms.com
Sun Sep 28 12:53:30 PDT 2008


"Jens Petersen" <juhpetersen at gmail.com> writes:

> Hi,
> I am still learning javascript, but here is a small patch with a few
> things I and js2.el noticed.

> Should I include changelog entries with my patches?

In the future, yes, and also if you format them using git format-patch,
that is helpful.  It is fine if you attach the result of git
format-patch to an e-mail, rather than sending it as an e-mail itself.

As far as the javascript lint results, I think they are mostly or
entirely bogus, because javascript lint first of all doesn't know what
global variables are available, and second it doesn't understand Mozilla
JavaScript 1.8, so it is confused by keywords like yield.

I applied the attached patch, though.

Thanks for your contribution.

-- 
Jeremy Maitin-Shepard


More information about the Conkeror mailing list