[Conkeror] [PATCH] google-search-results: use search result links for more commands

[John J Foerch]

David Kettler <kettler at internode.on.net> writes:
> Use browser_object_google_search_results_links as the default browser
> object for all interactive commands that normally use
> browser_object_links.  This commit adds follow-new-buffer,
> follow-new-buffer-background, follow-new-window and removes
> shell-command-on-url.
>
> The code is restructured a little too.
>
> ---
>
> It's clunky to have to explicitly list and override all relevant
> commands.  Alternatives:
>
>   - trawl through interactive_commands and set
>     buffer.default_browser_object_classes for those that have
>     browser_object == browser_object_links.
>
>     That's very heavy handed though.
>
>   - Have some further indirection in the hints or browser_object
>     system to allow classes to be overridden.  Perhaps this relates to
>     the generalized interactive extensions discussed at
>     http://bugs.conkeror.org/issue90.


Looks good.  Let's keep it simple and just list the overrides
explicitly, as you do in your patch.  The idea of a level of indirection
in the browser object system is a good one, though.  I'm not immediately
sure what form its implementation will take, but it is something to keep
in mind as we improve the system.

-- 
John Foerch