[Conkeror] [PATCH 1/2] download manager: show display name, allow target file name to change

[John J Foerch]

David Kettler <kettler at internode.on.net> writes:
>>   I am having problems downloading files since "download manager: show
>> display name, allow target file name to change".  The file downloads in
>> the background, but I get no download buffer, and conkeror spews errors:
>>
>> error: encountered unknown download in progress change
>> error: encountered unknown download in progress change
>> error: encountered unknown download in progress change
>
> Sorry, John, I broke it.  I've just pushed a fix.  See commit message
> included below for further info.
>
        
  Great, thank you for the quick fix.


> I hadn't realized that there are two ways to save files.  The save
> command uses the saveURI method of nsWebBrowserPersist, while visiting
> a download link ends up using the saveToDisk method of
> nsIHelperAppLauncherDialog.  The latter does the .part thing.  I was
> aware of the functionality from having previously used iceape, but I
> didn't realize that it is in the xul code that conkeror uses too.  The
> saveURI method does not offer anything similar, so I implemented the
> temp file work around.  If save_uri could use the
> nsIHelperAppLauncherDialog method then my temp file code won't be
> needed.  That would be great.


  Okay.  This can be delayed until later.  If you have any good ideas
about better abstration, feel free.  Without having looked closely at
the code in a while, the idea of only using nsIHelperAppLauncherDialog
rings an alarm in my mind because by its name, it is obviously intended
for use in dialogs, which is not the case with save_uri.

-- 
John Foerch