[Greasemonkey] Incoming breakage?

Aaron Boodman zboogs at gmail.com
Fri Apr 8 04:07:38 EDT 2005


Ok, after some research, i have reached this answer:

Probably not. the download off of asa's page does not work anymore,
but if I'm reading that URL right, it's just the regular nightly build
from the fifth. One would assume then that tonight's build also
includes the same change.

If so, then greasemonkey works fine with the following tiny change:

--- src/content/greasemonkey.js Fri Apr  8 01:23:22 2005
Fri Apr  8 02:47:52 2005
@@ -9,6 +9,7 @@
   this.loadDoc = function(e) {
     var docId;
     var document = e.originalTarget;
+    var win = e.explicitOriginalTarget.defaultView;
 
     if (!document.__gmId) {
       document.__gmId = nextDocId++;
@@ -22,7 +23,7 @@
     //than the one the script's on.
     docId = document.__gmId;
     
-    e.view.GM_registerMenuCommand = 
+    win.GM_registerMenuCommand = 
       function(commandName, commandCallback) { 
         registerMenuCommand(docId, commandName, commandCallback);
       }; 

On Apr 7, 2005 11:08 AM, Aaron Boodman <zboogs at gmail.com> wrote:
> Possibly. I have to check it out. I am definitely not an XUL/XBL
> expert (I can barely read that bug report), but presumably if they are
> breaking this, there is another way to do it. Perhaps this way will be
> more elegant. Let me test it out tonight and see what happens.
> 
> Thanks for the heads up. If anybody here can explain this in more
> detail, I'd be appreciative.
> 
> --
> Aaron
> 
> On Apr 7, 2005 10:46 AM, Matthias Bauer
> <ml-greasemonkey-42imk83y at moeffju.net> wrote:
> > Are you aware of
> >
> > http://weblogs.mozillazine.org/asa/archives/007898.html
> >
> > which refers to
> >
> > https://bugzilla.mozilla.org/show_bug.cgi?id=281988
> > Summary: Stop sharing DOM object wrappers between content and chrome
> >
> > This probably will break GreaseMonkey hard, right?
> >
> > -Matt
> > _______________________________________________
> > Greasemonkey mailing list
> > Greasemonkey at mozdev.org
> > http://mozdev.org/mailman/listinfo/greasemonkey
> >
>


More information about the Greasemonkey mailing list